Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1285 +/- ##
===========================================
+ Coverage 86.69% 86.71% +0.02%
===========================================
Files 337 337
Lines 84107 83979 -128
Branches 3126 4750 +1624
===========================================
- Hits 72919 72826 -93
+ Misses 11188 11130 -58
- Partials 0 23 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
One comment.
Otherwise this looks great. I particularly like that the LiteAdaptor, in particular LiteElement, is no longer dependent on mathjax at all.
…in node. Move SREfeature setup into the speech worker.
Yes, I am glad to be able to remove that code as well. It was never ideal, but worked for what we needed. This is much cleaner, so for that reason, I'm glad we ran into the problem and were able to fix it in a better way. |
Update/sre version
Improve mathmap configuration
2 participants
This PR resolves the problems we are having with using the worker code from the CDN. It rurns out that jsdelivr won't serve the HTML file for the worker pool (it wraps it in al in a
<pre>), so it doesn't run the code that starts the worker. That ends up being a pretty big problem.I will write more about it tomorrow, but for now, the big change is to remove the worker pool entirely and have the WebWorker.ts file create the worker itself and communicate directly with it. The trick is to make a dynamically created
blobobject that imports the needed CDN file after a bit of setup. Because the CDN has access-control headers that allow that, it works. It also works if you host it on your own server, as there is no cross-origin issue.This is a cleaner solution than our original, which is nice. I was able to remove a lot of hacky code from the liteDOM, for example.
There is still an issue with the clearspeak menu, but I wanted to give you a chance to try it out and see what you think.
You will need to rebuild everything, including running the lab:sre script.